-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ecs): add codepipeline deploy-action to ecs cluster #2050
feat(ecs): add codepipeline deploy-action to ecs cluster #2050
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @aweiher , a really high quality contribution! Just a few small comments/questions.
Thanks for taking the time to do this!
packages/@aws-cdk/aws-codepipeline/test/integ.pipeline-ecs-deploy.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-codepipeline/test/integ.pipeline-ecs-deploy.ts
Outdated
Show resolved
Hide resolved
The build failure seems like something transient. Can you rebase, and try again? (there are some conflicts with current master, so that would have to be done sometime anyway). Thanks! |
Hej @skinny85 - Thank you very much for your code-review! :) I will fix the issues in the next days 👍 |
Hey @aweiher , there's been a pretty big revolution in the way the Actions are represented in code in PR #2098 . This might make rebasing this PR particularly challenging. Given how close to the final shape this PR is, I'd be willing to take it over from you - I was the one doing the changes in #2098, so I'm quite familiar with what needs to be changed in this new way of doing things. Let me know! |
Hi @skinny85 - No Problem, take this PR over. I really wanted to implement this by myself, but an other task is eating all my time unfortunately. I added one commit/comment regarding the permission, hope it helps. |
Thanks, will do! |
b198296
to
c73b7aa
Compare
I've rebased the PR on top of master. @RomainMuller and @SoManyHs , I would appreciate if you took a look. |
c73b7aa
to
2ad6372
Compare
Missed a new feature in ECS when rebasing that changes the expected file for the integ tests. |
packages/@aws-cdk/aws-codepipeline-actions/lib/ecs/deploy-action.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-codepipeline-actions/lib/ecs/deploy-action.ts
Outdated
Show resolved
Hide resolved
2ad6372
to
657411f
Compare
No Unit-Test, one Integration Test ist present. The similar compontent
s3 deploy-action
has no unit-test (didnt found it), so I oriented there. Please give me feedback when required.I have tested the integration test in my private AWS Account, and it worked.
Notes:
toCodePipelineInvokeAction
(on service?) asservice
andrepository
is required, as I didnt figured out an easy api for this. Need feedback if this is required.ecs:*
for*
), I oriented on the default AWS CodePipeline Role: https://docs.aws.amazon.com/codepipeline/latest/userguide/how-to-custom-role.htmlsts:AssumeRole
andiam:PassRole
for*
- same reason as point before. The following would be ideal, but I didnt figured out how to construct this with cdk:Fixes #1386
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.